RevenueManager.sol

[UNKNOWN] Precision Loss in Protocol Fee Calculation

The getProtocolFee() function is currently returning a value that rounds up based on the input. We are unsure if this is an intentional update as the code comments do not make this design decision clear. We imagine that this is a design decision to ensure that the protocol fee always gets the lion's share, but we wanted to confirm.

function getProtocolFee(uint _amount) public view returns (uint protocolFee_) {
    return (_amount * protocolFee + MAX_PROTOCOL_FEE - 1) / MAX_PROTOCOL_FEE;
}